Skip to content

bpo-40637: Add option to disable builtin hashes #20121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented May 15, 2020

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40637

Automerge-Triggered-By: @tiran

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good. This saves compile time for distro packages. one nit on the flag name.

tiran added 2 commits May 15, 2020 23:08
Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member Author

tiran commented May 15, 2020

Thanks! I forgot to update the news entry.

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9b60e55 into python:master May 15, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: @tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants